spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixcheung <...@git.apache.org>
Subject [GitHub] spark pull request #15051: [SPARK-17499][ML][MLLib] make the default params ...
Date Sun, 11 Sep 2016 19:35:09 GMT
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15051#discussion_r78301008
  
    --- Diff: R/pkg/R/mllib.R ---
    @@ -694,8 +694,8 @@ setMethod("predict", signature(object = "KMeansModel"),
     #' }
     #' @note spark.mlp since 2.1.0
     setMethod("spark.mlp", signature(data = "SparkDataFrame"),
    -          function(data, blockSize = 128, layers = c(3, 5, 2), solver = "l-bfgs", maxIter
= 100,
    -                   tol = 0.5, stepSize = 1, seed = 1) {
    +          function(data, blockSize = 128, layers, solver = "l-bfgs", maxIter = 100,
    --- End diff --
    
    I think the preference would be to have `layers = c()` - it helps to show that it should
be a vector of potentially multiple values


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message