spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #14719: [SPARK-17154][SQL] Wrong result can be returned o...
Date Wed, 07 Sep 2016 13:25:24 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14719#discussion_r77820548
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
    @@ -524,11 +524,16 @@ class Analyzer(
               val newRight = right transformUp {
                 case r if r == oldRelation => newRelation
               } transformUp {
    -            case other => other transformExpressions {
    -              case a: Attribute =>
    -                attributeRewrites.get(a).getOrElse(a).withQualifier(a.qualifier)
    -            }
    +            case other =>
    +              val transformed = other transformExpressions {
    +                case a: Attribute =>
    +                  attributeRewrites.get(a).getOrElse(a).withQualifier(a.qualifier)
    +              }
    +
    +              transformed.setPlanId(other.planId)
    +              transformed
               }
    +          newRight.setPlanId(right.planId)
    --- End diff --
    
    I don't quite understand this. If it's a self-join, and `left` and `right` is same plan(same
plan id), then after `dedupRight`, `left` and `right` is not same plan but still have same
plan id right? How do we resolve `UnresolvedAttribute` with plan id? I think it's still ambiguous.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message