spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From WeichenXu123 <...@git.apache.org>
Subject [GitHub] spark pull request #14923: [SPARK-17363][ML][MLLib] fix MultivariantOnlineSu...
Date Fri, 02 Sep 2016 14:10:54 GMT
Github user WeichenXu123 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14923#discussion_r77352136
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala
---
    @@ -233,7 +233,7 @@ class MultivariateOnlineSummarizer extends MultivariateStatisticalSummary
with S
       override def numNonzeros: Vector = {
         require(totalWeightSum > 0, s"Nothing has been added to this summarizer.")
    --- End diff --
    
    yeah, here it should use `totalCnt`, I update it.
    and I fix the testcase, now the existing testcase already cover the method.
    thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message