spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keypointt <...@git.apache.org>
Subject [GitHub] spark pull request #13584: [SPARK-15509][ML][SparkR] R MLlib algorithms shou...
Date Thu, 01 Sep 2016 23:34:47 GMT
Github user keypointt commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13584#discussion_r77272735
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/RWrapperUtils.scala ---
    @@ -35,13 +35,37 @@ object RWrapperUtils extends Logging {
        */
       def checkDataColumns(rFormula: RFormula, data: Dataset[_]): Unit = {
         if (data.schema.fieldNames.contains(rFormula.getLabelCol)) {
    -      logWarning("data containing 'label' column, so change its name to avoid conflict")
    -      rFormula.setLabelCol(rFormula.getLabelCol + "_output")
    +      val newLabelName = convertToUniqueName(rFormula.getLabelCol, data.schema.fieldNames)
    --- End diff --
    
    ok, it's a better way


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message