spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #14897: [SPARK-17338][SQL] add global temp view
Date Thu, 01 Sep 2016 00:30:22 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14897#discussion_r77097547
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
    @@ -255,3 +287,43 @@ case class AlterViewAsCommand(
         session.sessionState.catalog.alterTable(updatedViewMeta)
       }
     }
    +
    +/**
    + * Drops a view which matches the given name.
    + *
    + * If the view name contains database prefix, this command will drop a permanent view
matching the
    + * given name, or throw an exception if view not exist. Else, this command will try to
drop a local
    + * temporary view first, if view not exist, try global temporary view next, if still
not exist, try
    --- End diff --
    
    Yes. Right. Up to now, all happens in the same session. So, temporary view is created
after permanent view always. It works like STACK.
    
    However, this is a global view made by other session. So, it does not work like STACK.
Even in the same session, if we execute 'create temporary view' and 'create global view',
we must delete the local temporary view first. So, it seems more serious to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message