Return-Path: <reviews-return-414138-archive-asf-public=cust-asf.ponee.io@spark.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id D4D6D200B7C
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 25 Aug 2016 04:37:52 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id D353B160AC1; Thu, 25 Aug 2016 02:37:52 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 1DB0F160AB1
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 25 Aug 2016 04:37:51 +0200 (CEST)
Received: (qmail 44874 invoked by uid 500); 25 Aug 2016 02:37:51 -0000
Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@spark.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@spark.apache.org>
List-Post: <mailto:reviews@spark.apache.org>
List-Id: <reviews.spark.apache.org>
Delivered-To: mailing list reviews@spark.apache.org
Received: (qmail 44859 invoked by uid 99); 25 Aug 2016 02:37:51 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Aug 2016 02:37:51 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id EE1FDE00DB; Thu, 25 Aug 2016 02:37:50 +0000 (UTC)
From: zjffdu <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-14744-spark@git.apache.org>
In-Reply-To: <git-pr-14744-spark@git.apache.org>
Subject: [GitHub] spark pull request #14744: [SPARK-17178][SPARKR][SPARKSUBMIT] Allow to set s...
Content-Type: text/plain
Message-Id: <20160825023750.EE1FDE00DB@git1-us-west.apache.org>
Date: Thu, 25 Aug 2016 02:37:50 +0000 (UTC)
archived-at: Thu, 25 Aug 2016 02:37:53 -0000

Github user zjffdu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14744#discussion_r76172436
  
    --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java ---
    @@ -336,7 +336,8 @@
                 join(File.separator, sparkHome, "R", "lib", "SparkR", "profile", "shell.R"));
     
         List<String> args = new ArrayList<>();
    -    args.add(firstNonEmpty(System.getenv("SPARKR_DRIVER_R"), "R"));
    +    args.add(firstNonEmpty(firstNonEmpty(conf.get(SparkLauncher.SPARKR_R_SHELL),
    --- End diff --
    
    ah, right, my mistake. :(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org