Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 095D4200B68 for ; Fri, 19 Aug 2016 11:16:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 07ECE160AAC; Fri, 19 Aug 2016 09:16:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 47775160A8E for ; Fri, 19 Aug 2016 11:16:48 +0200 (CEST) Received: (qmail 63357 invoked by uid 500); 19 Aug 2016 09:16:47 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 63341 invoked by uid 99); 19 Aug 2016 09:16:47 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Aug 2016 09:16:47 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 27C7AE00D6; Fri, 19 Aug 2016 09:16:47 +0000 (UTC) From: cloud-fan To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source... Content-Type: text/plain Message-Id: <20160819091647.27C7AE00D6@git1-us-west.apache.org> Date: Fri, 19 Aug 2016 09:16:47 +0000 (UTC) archived-at: Fri, 19 Aug 2016 09:16:49 -0000 Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r75450667 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -584,13 +579,8 @@ case class AlterTableSetLocationCommand( object DDLUtils { - - def isDatasourceTable(props: Map[String, String]): Boolean = { - props.contains(DATASOURCE_PROVIDER) - } - def isDatasourceTable(table: CatalogTable): Boolean = { - isDatasourceTable(table.properties) + table.provider.isDefined && table.provider.get != "hive" --- End diff -- fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org