Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 26228200B78 for ; Fri, 19 Aug 2016 07:22:58 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 24AC8160AB7; Fri, 19 Aug 2016 05:22:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 64A0A160AAE for ; Fri, 19 Aug 2016 07:22:57 +0200 (CEST) Received: (qmail 23676 invoked by uid 500); 19 Aug 2016 05:22:56 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 23665 invoked by uid 99); 19 Aug 2016 05:22:56 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Aug 2016 05:22:56 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E8778E04AF; Fri, 19 Aug 2016 05:22:55 +0000 (UTC) From: junyangq To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark issue #14705: [SPARK-16508][SparkR] Fix CRAN undocumented/duplicated a... Content-Type: text/plain Message-Id: <20160819052255.E8778E04AF@git1-us-west.apache.org> Date: Fri, 19 Aug 2016 05:22:55 +0000 (UTC) archived-at: Fri, 19 Aug 2016 05:22:58 -0000 Github user junyangq commented on the issue: https://github.com/apache/spark/pull/14705 @shivaram I found perhaps a neat way to document R'glm if we don't want to remove it is to use `@inheritParams stats::glm`. That will bring in all the parameters from `stats::glm` not listed in SparkR's glm. That also means we need slight modification of the `data` description: something like "a SparkDataFrame or R's glm data for training." --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org