Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: HyukjinKwon <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-14538-spark@git.apache.org>
In-Reply-To: <git-pr-14538-spark@git.apache.org>
Subject: [GitHub] spark pull request #14538: [SPARK-16588][SQL][FOLLOWUP] Rename approxCountDi...
Content-Type: text/plain
Message-Id: <20160808230211.2C505E040E@git1-us-west.apache.org>
Date: Mon,  8 Aug 2016 23:02:11 +0000 (UTC)
archived-at: Mon, 08 Aug 2016 23:02:13 -0000

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14538#discussion_r73972010
  
    --- Diff: python/pyspark/sql/functions.py ---
    @@ -112,11 +112,8 @@ def _():
         'sinh': 'Computes the hyperbolic sine of the given value.',
         'tan': 'Computes the tangent of the given value.',
         'tanh': 'Computes the hyperbolic tangent of the given value.',
    -    'toDegrees': 'Converts an angle measured in radians to an approximately equivalent angle ' +
    -                 'measured in degrees.',
    -    'toRadians': 'Converts an angle measured in degrees to an approximately equivalent angle ' +
    -                 'measured in radians.',
    -
    +    'toDegrees': '.. note:: Deprecated in 2.0, use degrees instead.',
    --- End diff --
    
    I will create a separate issue because SPARK-16588 is fixed in 2.0.0 if it makes sense. Sorry, I was just confused.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org