Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: ericl <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-14218-spark@git.apache.org>
In-Reply-To: <git-pr-14218-spark@git.apache.org>
Subject: [GitHub] spark pull request #14218: [SPARK-16563][SQL] fix spark sql thrift server Fe...
Content-Type: text/plain
Message-Id: <20160807191830.394DAE2C1A@git1-us-west.apache.org>
Date: Sun,  7 Aug 2016 19:18:30 +0000 (UTC)
archived-at: Sun, 07 Aug 2016 19:18:32 -0000

Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14218#discussion_r73807486
  
    --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala ---
    @@ -91,6 +93,57 @@ class HiveThriftBinaryServerSuite extends HiveThriftJdbcTest {
         }
       }
     
    +  test("SPARK-16563 ThriftCLIService FetchResults repeat fetching result") {
    +    withCLIServiceClient { client =>
    +      val user = System.getProperty("user.name")
    +      val sessionHandle = client.openSession(user, "")
    +
    +      withJdbcStatement { statement =>
    +        val queries = Seq(
    +          "SET spark.sql.shuffle.partitions=3",
    +          "DROP TABLE IF EXISTS test",
    --- End diff --
    
    Dropping the wrong table?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org