Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: holdenk <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-14469-spark@git.apache.org>
In-Reply-To: <git-pr-14469-spark@git.apache.org>
Subject: [GitHub] spark pull request #14469: [SPARK-16700] [PYSPARK] [SQL] create DataFrame fr...
Content-Type: text/plain
Message-Id: <20160803213433.11B8EE3839@git1-us-west.apache.org>
Date: Wed,  3 Aug 2016 21:34:33 +0000 (UTC)
archived-at: Wed, 03 Aug 2016 21:34:35 -0000

Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14469#discussion_r73425805
  
    --- Diff: python/pyspark/sql/session.py ---
    @@ -432,14 +430,9 @@ def createDataFrame(self, data, schema=None, samplingRatio=None):
                 ``byte`` instead of ``tinyint`` for :class:`pyspark.sql.types.ByteType`. We can also use
                 ``int`` as a short name for ``IntegerType``.
             :param samplingRatio: the sample ratio of rows used for inferring
    +        :param verifySchema: verify data types of every row against schema.
             :return: :class:`DataFrame`
     
    -        .. versionchanged:: 2.0
    --- End diff --
    
    Out of interest why are we removing this note but keeping the other 2.0 change note? Just wondering so that when I'm making my changes for 2.1 I can do the right thing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org