spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stibbons <...@git.apache.org>
Subject [GitHub] spark pull request #14567: [SPARK-16992][PYSPARK] Python Pep8 formatting and...
Date Wed, 31 Aug 2016 11:04:31 GMT
Github user Stibbons commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14567#discussion_r76967736
  
    --- Diff: dev/py-validate.sh ---
    @@ -0,0 +1,110 @@
    +#!/usr/bin/env bash
    --- End diff --
    
    My point of view:
    - don't enforce it right away, just agree on the style
    - execute manualy on some files (in my next PR, it's on documentation), and on small big
bang PRs
    - then enforce automatic formatting (preferably with Yapf) on some files. On Buildbot
we use a git commit hook to check python files automatically, apply some pep8 formatting,
execute pylint,...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message