spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...
Date Wed, 31 Aug 2016 10:59:58 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14712#discussion_r76967205
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala
---
    @@ -33,7 +33,8 @@ import org.apache.spark.util.Utils
     case class LogicalRelation(
         relation: BaseRelation,
         expectedOutputAttributes: Option[Seq[Attribute]] = None,
    -    metastoreTableIdentifier: Option[TableIdentifier] = None)
    +    metastoreTableIdentifier: Option[TableIdentifier] = None,
    +    inheritedStats: Option[Statistics] = None)
    --- End diff --
    
     having `metastoreTableIdentifier` inside `LogicalRelation` means we already hack the
table concept into `LogicalRelation`, how about we go further and put `CatalogTable` in `LogicalRelation`?
I think it's better than taking a `TableIdentifier` and a `Statistics` object.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message