spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...
Date Wed, 31 Aug 2016 05:21:45 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14712#discussion_r76926133
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala
---
    @@ -401,6 +401,13 @@ private[spark] class HiveExternalCatalog(conf: SparkConf, hadoopConf:
Configurat
         }
       }
     
    +  override def alterTableStats(tableDefinition: CatalogTable): Unit = withClient {
    --- End diff --
    
    Yeah, agree with @cloud-fan . 
    
    If we want to set it using `alter table`, we should use the dedicated command (just like
what Hive does):
    ```SQL
    ALTER TABLE UPDATE STATISTICS SET
    ```
    Let us remove `alterTableStats` and minimize the code changes? We can discuss how to do
it properly when we start this JIRA: https://issues.apache.org/jira/browse/SPARK-17282


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message