spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maropu <...@git.apache.org>
Subject [GitHub] spark issue #10896: [SPARK-12978][SQL] Skip unnecessary final group-by when ...
Date Tue, 30 Aug 2016 09:55:50 GMT
Github user maropu commented on the issue:

    https://github.com/apache/spark/pull/10896
  
    @cloud-fan @liancheng yea, adding a new rule after `EnsureRequirements` sounds good to
me. One question; creating a partial aggregation in the planner and removing it in the new
rule seem to be kind of wasteful, so is it a bad idea to create a partial aggregation in the
rule? Physical plans is always correct with/without partial aggregations and it is one of
optimizations.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message