spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clockfly <...@git.apache.org>
Subject [GitHub] spark pull request #14868: Implements percentile_approx aggregation function...
Date Mon, 29 Aug 2016 21:27:52 GMT
Github user clockfly commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14868#discussion_r76690870
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/QuantileSummaries.scala
---
    @@ -41,7 +41,7 @@ import org.apache.spark.sql.catalyst.util.QuantileSummaries.Stats
      * @param count the count of all the elements *inserted in the sampled buffer*
      *              (excluding the head buffer)
      */
    -class QuantileSummaries(
    +case class QuantileSummaries(
    --- End diff --
    
    Make it as a case class, so that we can use the expression encoder to serialize it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message