spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark issue #14842: [SPARK-10747][SQL] Support NULLS FIRST|LAST clause in OR...
Date Sun, 28 Aug 2016 16:42:33 GMT
Github user hvanhovell commented on the issue:

    https://github.com/apache/spark/pull/14842
  
    Ok, so ASCENDING and DESCENDING have different NULLS behavior:
    - ASCENDING: NULLS FIRST
    - DESCENDING: NULLS LAST
    
    I really like to avoid `nulls` being passed around and I also like to avoid a third case
we need to deal with. My suggestion would be:
    
    - Only deal with the ASC NULLS FIRST/ASC NULLS LAST/DESC NULLS FIRST/DESC NULL LAST scenarios
in prefix sort (and to drop the null scenario).  
    - Encode the null default behavior in the `SortDirection` and make the default nullOrdering
parameter in `SortOrder` use that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message