spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xwu0226 <...@git.apache.org>
Subject [GitHub] spark pull request #14842: [SPARK-10747][SQL] Support NULLS FIRST|LAST claus...
Date Sun, 28 Aug 2016 16:25:55 GMT
Github user xwu0226 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14842#discussion_r76534903
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
---
    @@ -36,11 +40,19 @@ case object Descending extends SortDirection {
       override def sql: String = "DESC"
     }
     
    +case object NullFirst extends NullOrdering{
    +  override def sql: String = "NULLS FIRST"
    +}
    +
    +case object NullLast extends NullOrdering{
    +  override def sql: String = "NULLS LAST"
    +}
    +
     /**
      * An expression that can be used to sort a tuple.  This class extends expression primarily
so that
      * transformations over expression will descend into its child.
      */
    -case class SortOrder(child: Expression, direction: SortDirection)
    +case class SortOrder(child: Expression, direction: SortDirection, nullOrder: NullOrdering
= null)
    --- End diff --
    
    Without giving default value for this parameter, there are about no more than 100 lines
of code change in different places, including test cases. Setting "nulls first" as default
behavior may break a lot of test cases that put nulls first when ASC, and last when DESC.
The original default behavior will change. If this is expected, I will make the change. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message