spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #14746: [SPARK-17180] [SQL] Fix View Resolution Order in ...
Date Fri, 26 Aug 2016 06:41:48 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14746#discussion_r76370760
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
    @@ -105,7 +105,13 @@ case class CreateViewCommand(
         }
         val sessionState = sparkSession.sessionState
     
    -    if (isTemporary) {
    +    // 1) CREATE VIEW: create a temp view when users explicitly specify the keyword TEMPORARY;
    +    //                 otherwise, create a permanent view no matter whether the temporary
view
    +    //                 with the same name exists or not.
    +    // 2) ALTER VIEW: alter the temporary view if the temp view exists; otherwise, try
to alter
    --- End diff --
    
    True, let me think about it. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message