spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #14597: [SPARK-17017][MLLIB][ML] add a chiSquare Selector...
Date Mon, 22 Aug 2016 08:18:28 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14597#discussion_r75634212
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
    @@ -54,6 +54,29 @@ private[feature] trait ChiSqSelectorParams extends Params
     
       /** @group getParam */
       def getNumTopFeatures: Int = $(numTopFeatures)
    +
    +  final val percentile = new DoubleParam(this, "percentile",
    +    "Percentile of features that selector will select, ordered by statistics value descending.",
    +    ParamValidators.gtEq(0))
    +  setDefault(percentile -> 10)
    --- End diff --
    
    I think we still need to change this, because other functions like the SQL percentile
function accept values in [0,1] instead of [0,100]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message