spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pzz2011 <...@git.apache.org>
Subject [GitHub] spark pull request #9084: [SPARK-10983] Unified memory manager
Date Sun, 21 Aug 2016 13:41:32 GMT
Github user pzz2011 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9084#discussion_r75595379
  
    --- Diff: core/src/main/scala/org/apache/spark/memory/MemoryManager.scala ---
    @@ -40,6 +41,10 @@ private[spark] abstract class MemoryManager {
         _memoryStore
       }
     
    +  // Amount of execution/storage memory in use, accesses must be synchronized on `this`
    +  protected var _executionMemoryUsed: Long = 0
    --- End diff --
    
    why here is protected?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message