spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #14625: [SPARK-17045] [SQL] Build/move Join-related test ...
Date Sun, 21 Aug 2016 02:53:23 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14625#discussion_r75588146
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
    @@ -245,6 +245,10 @@ class SQLQueryTestSuite extends QueryTest with SharedSQLContext {
     
         (1 to 100).map(i => (i, i.toString)).toDF("key", "value").createOrReplaceTempView("testdata")
     
    +    Seq((1, 1), (1, 2), (2, 1), (2, 2), (3, 1), (3, 2))
    --- End diff --
    
    previously we have 3 pre-loaded tables: `testdata`, `arraydata`, `mapdata`, which are
key-value table, array type table and map type table. For the new join tests, I think only
`lowerCaseData`, `upperCaseData`, `srcpart` make sense, why can't we use `testdata` for `testData2`,
`src` and `src2`? They are all key-value tables.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message