spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkbradley <>
Subject [GitHub] spark pull request #14547: [SPARK-16718][MLlib] gbm-style treeboost
Date Fri, 19 Aug 2016 17:50:49 GMT
Github user jkbradley commented on a diff in the pull request:
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala ---
    @@ -183,24 +191,18 @@ private[ml] trait DecisionTreeParams extends PredictorParams
     private[ml] trait TreeClassifierParams extends Params {
    +  // Impurity should be overriden when setting a default. This should be a def, but has
    --- End diff --
    typo: overridden
    Also, did you try generating the docs?  If you use a def here but override it elsewhere
as a val, then does it show up as a val in the docs?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message