spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #14118: [SPARK-16462][SPARK-16460][SPARK-15144][SQL] Make...
Date Thu, 18 Aug 2016 12:55:11 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14118#discussion_r75302012
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
    @@ -370,7 +370,8 @@ class DataFrameReader private[sql](sparkSession: SparkSession) extends
Logging {
        * from values being read should be skipped.</li>
        * <li>`ignoreTrailingWhiteSpace` (default `false`): defines whether or not trailing
        * whitespaces from values being read should be skipped.</li>
    -   * <li>`nullValue` (default empty string): sets the string representation of
a null value.</li>
    +   * <li>`nullValue` (default empty string): sets the string representation of
a null value. Since
    --- End diff --
    
    BTW, there would be the same documentation in `readwriter.py` and `DataStreamReader`.
I guess we should fix them too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message