spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark issue #14625: [SPARK-17045] [SQL] Moving Auto_Joins from HiveCompatibi...
Date Sat, 13 Aug 2016 02:43:30 GMT
Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/14625
  
    I think `HiveCompatibilitySuite` has 2 purposes:
    
    1. using Hive's test to improve our test coverage
    2. make sure our result is same with Hive for same query(with blacklist)
    
    Now we have `SQLQueryTestSuite`, we should use it to improve test coverage instead of
`HiveCompatibilitySuite`. But this doesn't mean we should copy the test from `HiveCompatibilitySuite`
to `SQLQueryTestSuite`, a test with hundreds of input records doesn't make sense.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message