spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request #14397: [SPARK-16771][SQL] WITH clause should not fall in...
Date Wed, 10 Aug 2016 09:11:27 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14397#discussion_r74210475
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
    @@ -125,21 +125,23 @@ class Analyzer(
       object CTESubstitution extends Rule[LogicalPlan] {
         // TODO allow subquery to define CTE
         def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators  {
    -      case With(child, relations) => substituteCTE(child, relations)
    +      case With(child, relations) if relations.nonEmpty =>
    --- End diff --
    
    `relations` is a map. The iteration sequence of a map does not need the be the ordered
in which elements were added (Use a map larger than 4 to see this in action, e.g.: `Seq.tabulate(5)(i
=> ('a' + i).toChar.toString -> i).toMap`).
    
    So I think we need to change the data type in With to accommodate this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message