spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #14571: [SPARK-16983][SQL] Add `prettyName` for row_numbe...
Date Wed, 10 Aug 2016 04:16:33 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14571#discussion_r74183323
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
    @@ -478,6 +478,7 @@ object SizeBasedWindowFunction {
     case class RowNumber() extends RowNumberLike {
       override val evaluateExpression = rowNumber
       override def sql: String = "ROW_NUMBER()"
    --- End diff --
    
    Yep. We can remove `sql` here. The default implementation of `Expression` can handle this.
I will remove `sql` here. Thank you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message