spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #13146: [SPARK-13081][PYSPARK][SPARK_SUBMIT]. Allow set p...
Date Mon, 08 Aug 2016 23:36:35 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13146#discussion_r73975767
  
    --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
    @@ -64,6 +64,10 @@
       /** Configuration key for the number of executor CPU cores. */
       public static final String EXECUTOR_CORES = "spark.executor.cores";
     
    +  public static final String PYSPARK_DRIVER_PYTHON = "spark.pyspark.driver.python";
    --- End diff --
    
    I know, but this is a public as in "it's actually exposed to users" API. I'd rather avoid
adding more and more config keys to this class - especially when, like these, they're probably
not gonna be commonly used.
    
    Inside Spark, you can add the constants I suggested previously. But I'd prefer to keep
these new fields in `SparkLauncher` not public.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message