spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From holdenk <...@git.apache.org>
Subject [GitHub] spark pull request #14407: [SPARK-16779][TRIVIAL] Avoid using postfix operat...
Date Fri, 05 Aug 2016 21:24:01 GMT
Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14407#discussion_r73761555
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/FaultToleranceTest.scala ---
    @@ -113,7 +112,7 @@ private object FaultToleranceTest extends App with Logging {
         assertValidClusterState()
     
         killLeader()
    -    delay(30 seconds)
    +    delay(30.seconds)
    --- End diff --
    
    If the consesus is we want to keep the time based postfix operators then we can definitetly
narrow this down (unfortunatetly those files will remain whitelisted as a whole and won't
trigger any warnings so we won't necessarily notice if people start using other postfix operators
inside of them).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message