spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BryanCutler <...@git.apache.org>
Subject [GitHub] spark issue #11746: [SPARK-13602][CORE] Add shutdown hook to DriverRunner to...
Date Fri, 05 Aug 2016 18:36:37 GMT
Github user BryanCutler commented on the issue:

    https://github.com/apache/spark/pull/11746
  
    @vanzin would you mind taking a look at this if you have time?  It had gotten stagnant
but I think it still has some value.  
    
    In addition to the shutdown hook, I think changing the `finalState` var to be volatile
is needed since it's set then read in different threads, and also this class did not have
many unit tests.  Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message