spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eyalfa <...@git.apache.org>
Subject [GitHub] spark pull request #14444: [SPARK-16839] [SQL] redundant aliases after clean...
Date Fri, 05 Aug 2016 14:30:33 GMT
Github user eyalfa commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14444#discussion_r73701323
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
    @@ -669,7 +669,7 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with Logging {
             (st, (e: Expression) => e)
           case dt =>
             val st = CreateStruct(Seq(expressions.head)).dataType
    -        (st, (e: Expression) => CreateStruct(Seq(e)))
    +        (st, (e: Expression) => CreateStruct(Seq(e)).toCreateNamedStruct)
    --- End diff --
    
    @cloud-fan notice that in line 677 we're calling eval() on this expression.
    hence, once we made CreateStruct Unevaluable, we ust take measures to convert it into
something which can be evaluated in this stage. (this is related to 'inline-tables').


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message