spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From avulanov <...@git.apache.org>
Subject [GitHub] spark issue #12695: [SPARK-14914] Normalize Paths/URIs for windows.
Date Fri, 05 Aug 2016 11:09:08 GMT
Github user avulanov commented on the issue:

    https://github.com/apache/spark/pull/12695
  
    @vanzin This PR partly addresses a broader problem that path construction is not consistent
throughout Spark sources. Indeed, this is a potential source of bugs. Here is an example https://github.com/apache/spark/pull/13868#issuecomment-228932793.
However, author addresses the problem with regex, which does not seem to be optimal as @srowen
mentioned. I believe we should have a separate JIRA for making all path references and construction
error-prone and consistent, and check everything including shell scripts. For example, https://github.com/apache/spark/blob/master/build/mvn#L161
contains a reference to `${MVN_BIN} -someParameters` which will fail if maven path contains
a space.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message