spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <...@git.apache.org>
Subject [GitHub] spark pull request #13680: [SPARK-15962][SQL] Introduce implementation with ...
Date Thu, 04 Aug 2016 17:27:36 GMT
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13680#discussion_r73565969
  
    --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
    @@ -25,30 +25,36 @@
     import org.apache.spark.sql.types.*;
     import org.apache.spark.unsafe.Platform;
     import org.apache.spark.unsafe.array.ByteArrayMethods;
    +import org.apache.spark.unsafe.bitset.BitSetMethods;
     import org.apache.spark.unsafe.hash.Murmur3_x86_32;
     import org.apache.spark.unsafe.types.CalendarInterval;
     import org.apache.spark.unsafe.types.UTF8String;
     
     /**
      * An Unsafe implementation of Array which is backed by raw memory instead of Java objects.
      *
    - * Each tuple has three parts: [numElements] [offsets] [values]
    + * Each tuple has four parts: [numElements][null bits][values or offset][variable length
portion]
    --- End diff --
    
    Each array ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message