spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #14482: [SPARK-16879][SQL] unify logical plans for CREATE...
Date Thu, 04 Aug 2016 07:54:45 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14482#discussion_r73477314
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
---
    @@ -319,12 +319,26 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder {
         }
         val options = Option(ctx.tablePropertyList).map(visitPropertyKeyValues).getOrElse(Map.empty)
         val provider = ctx.tableProvider.qualifiedName.getText
    +    val schema = Option(ctx.colTypeList()).map(createStructType)
         val partitionColumnNames =
           Option(ctx.partitionColumnNames)
             .map(visitIdentifierList(_).toArray)
             .getOrElse(Array.empty[String])
         val bucketSpec = Option(ctx.bucketSpec()).map(visitBucketSpec)
     
    +    val tableDesc = CatalogTable(
    +      identifier = table,
    +      tableType = CatalogTableType.MANAGED,
    +      storage = CatalogStorageFormat.empty.copy(properties = options),
    +      schema = schema.getOrElse(new StructType),
    +      provider = Some(provider),
    --- End diff --
    
    yea, for example, https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala#L194


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message