spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #14482: [SPARK-16879][SQL] unify logical plans for CREATE...
Date Thu, 04 Aug 2016 07:19:05 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14482#discussion_r73472871
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
---
    @@ -933,23 +933,6 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder {
         val properties = Option(ctx.tablePropertyList).map(visitPropertyKeyValues).getOrElse(Map.empty)
         val selectQuery = Option(ctx.query).map(plan)
     
    -    // Ensuring whether no duplicate name is used in table definition
    -    val colNames = dataCols.map(_.name)
    -    if (colNames.length != colNames.distinct.length) {
    -      val duplicateColumns = colNames.groupBy(identity).collect {
    -        case (x, ys) if ys.length > 1 => "\"" + x + "\""
    -      }
    -      operationNotAllowed(s"Duplicated column names found in table definition of $name:
" +
    -        duplicateColumns.mkString("[", ",", "]"), ctx)
    -    }
    -
    -    // For Hive tables, partition columns must not be part of the schema
    --- End diff --
    
    `CREATE TABLE tab1 (key INT, value STRING) PARTITIONED BY (key INT)`
    
    for this query, the table definition is `(key int, value string, key int)`, and `PreprocessDDL`
will catch and throw exception


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message