spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From holdenk <...@git.apache.org>
Subject [GitHub] spark pull request #14467: [SPARK-16861][PYSPARK][CORE] Refactor PySpark acc...
Date Wed, 03 Aug 2016 19:28:38 GMT
Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14467#discussion_r73404059
  
    --- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala ---
    @@ -889,21 +891,40 @@ private class PythonAccumulatorParam(@transient private val serverHost:
String,
         socket
       }
     
    -  override def zero(value: JList[Array[Byte]]): JList[Array[Byte]] = new JArrayList
    +  override def reset(): Unit = {
    +    this._acc = new JArrayList[Array[Byte]]
    +  }
    +
    +  override def isZero: Boolean = {
    +    this._acc.isEmpty
    +  }
     
    -  override def addInPlace(val1: JList[Array[Byte]], val2: JList[Array[Byte]])
    -      : JList[Array[Byte]] = synchronized {
    +  override def copy(): PythonAccumulatorV2 = {
    +    val newAcc = new PythonAccumulatorV2(serverHost, serverPort)
    +    newAcc._acc = this._acc
    --- End diff --
    
    So the new accumulator API uses the copy method method inside of the `copyAndReset` which
is used inside of `writeReplace` during serialization. More generally you want to ship a "clean"
accumulator to the workers rather than something which is already potentially have some accumulated
values inside of it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message