Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: yanboliang <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-14378-spark@git.apache.org>
In-Reply-To: <git-pr-14378-spark@git.apache.org>
Subject: [GitHub] spark pull request #14378: [SPARK-16750] [ML] Fix GaussianMixture training f...
Content-Type: text/plain
Message-Id: <20160728032848.5AC5FE02A2@git1-us-west.apache.org>
Date: Thu, 28 Jul 2016 03:28:48 +0000 (UTC)
archived-at: Thu, 28 Jul 2016 03:28:50 -0000

Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14378#discussion_r72560646
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinMaxScaler.scala ---
    @@ -111,7 +111,7 @@ class MinMaxScaler @Since("1.5.0") (@Since("1.5.0") override val uid: String)
     
       @Since("2.0.0")
       override def fit(dataset: Dataset[_]): MinMaxScalerModel = {
    -    transformSchema(dataset.schema, logging = true)
    +    transformSchema(dataset.schema)
    --- End diff --
    
    It's a good question. Since ```MinMaxScaler``` override ```transformSchema``` with no argument ```logging```, we should use that one rather than the function in the base class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org