Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: viirya <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-14296-spark@git.apache.org>
In-Reply-To: <git-pr-14296-spark@git.apache.org>
Subject: [GitHub] spark pull request #14296: [SPARK-16639][SQL] The query with having conditio...
Content-Type: text/plain
Message-Id: <20160722081402.CCB2CE058E@git1-us-west.apache.org>
Date: Fri, 22 Jul 2016 08:14:02 +0000 (UTC)
archived-at: Fri, 22 Jul 2016 08:14:04 -0000

Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14296#discussion_r71842274
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ---
    @@ -1207,6 +1207,12 @@ class Analyzer(
                     val alias = Alias(ae, ae.toString)()
                     aggregateExpressions += alias
                     alias.toAttribute
    +              case ne: NamedExpression => ne
    +              case e: Expression if grouping.exists(_.semanticEquals(e)) &&
    --- End diff --
    
    Only push down the group by expressions or aggregate expressions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org