Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: rxin <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-13912-spark@git.apache.org>
In-Reply-To: <git-pr-13912-spark@git.apache.org>
Subject: [GitHub] spark pull request #13912: [SPARK-16216][SQL] CSV data
 source supports custo...
Content-Type: text/plain
Message-Id: <20160719055408.663AADFAF5@git1-us-west.apache.org>
Date: Tue, 19 Jul 2016 05:54:08 +0000 (UTC)

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13912#discussion_r71275955
  
    --- Diff: python/pyspark/sql/readwriter.py ---
    @@ -328,6 +328,10 @@ def csv(self, path, schema=None, sep=None, encoding=None, quote=None, escape=Non
                                applies to both date type and timestamp type. By default, it is None
                                which means trying to parse times and date by
                                ``java.sql.Timestamp.valueOf()`` and ``java.sql.Date.valueOf()``.
    +        :param timezone: defines the timezone to be used for both date type and timestamp type.
    +                         If a timezone is specified in the data, this will load them after
    --- End diff --
    
    Why not just have timezone as part of the dateFormat, so users can specify it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org