Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 795A319920 for ; Fri, 15 Jul 2016 08:29:51 +0000 (UTC) Received: (qmail 460 invoked by uid 500); 15 Jul 2016 08:29:51 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 435 invoked by uid 500); 15 Jul 2016 08:29:51 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 422 invoked by uid 99); 15 Jul 2016 08:29:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jul 2016 08:29:51 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0222EE0A3F; Fri, 15 Jul 2016 08:29:51 +0000 (UTC) From: gatorsmile To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #14132: [SPARK-16475][SQL] Broadcast Hint for SQL Queries Content-Type: text/plain Message-Id: <20160715082951.0222EE0A3F@git1-us-west.apache.org> Date: Fri, 15 Jul 2016 08:29:51 +0000 (UTC) Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14132#discussion_r70938037 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -84,7 +84,8 @@ class Analyzer( Batch("Substitution", fixedPoint, CTESubstitution, WindowsSubstitution, - EliminateUnions), + EliminateUnions, + SubstituteHint), --- End diff -- Like `EliminateUnions`, please rename it to `SubstituteHints` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org