Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: cloud-fan <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-14036-spark@git.apache.org>
In-Reply-To: <git-pr-14036-spark@git.apache.org>
Subject: [GitHub] spark pull request #14036: [SPARK-16323] [SQL] Add
 IntegerDivide to avoid un...
Content-Type: text/plain
Message-Id: <20160712061054.235C1DFFF8@git1-us-west.apache.org>
Date: Tue, 12 Jul 2016 06:10:54 +0000 (UTC)

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14036#discussion_r70381897
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala ---
    @@ -237,6 +229,9 @@ case class Divide(left: Expression, right: Expression)
         }
       }
     
    +  // Used by doGenCode
    +  protected def divide(eval1: ExprCode, eval2: ExprCode, javaType: String): String
    --- End diff --
    
    I don't think we need this abstraction. [this one](https://github.com/apache/spark/pull/14036/files#diff-1516b10738479bbe190fb4e239258473L252) already covers both fraction and integral


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org