spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nwbvt <...@git.apache.org>
Subject [GitHub] spark pull request #14352: Fix description of spark.speculation.quantile
Date Mon, 25 Jul 2016 22:23:04 GMT
GitHub user nwbvt opened a pull request:

    https://github.com/apache/spark/pull/14352

    Fix description of spark.speculation.quantile

    ## What changes were proposed in this pull request?
    
    Minor doc fix regarding the spark.speculation.quantile configuration parameter.  It incorrectly
states it should be a percentage, when it should be a fraction.
    
    ## How was this patch tested?
    
    (Please explain how this patch was tested. E.g. unit tests, integration tests, manual
tests)
    
    
    (If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
    
    I tried building the documentation but got some unidoc errors.  I also got them when building
off origin/master, so I don't think I caused that problem.  I did run the web app and saw
the changes reflected as expected.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nwbvt/spark master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/14352.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14352
    
----
commit d4bf67c74fff52bf4c5da68e0750740db0b87c15
Author: Nicholas Brown <nbrown@adroitdigital.com>
Date:   2016-07-25T21:35:30Z

    Fix description of spark.speculation.quantile
    Percentage implies it is a number between 0 and 100, not 0 and 1

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message