spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From WeichenXu123 <...@git.apache.org>
Subject [GitHub] spark pull request #14286: [SPARK-16653][ML][Optimizer] update ANN convergen...
Date Wed, 20 Jul 2016 15:24:08 GMT
GitHub user WeichenXu123 opened a pull request:

    https://github.com/apache/spark/pull/14286

    [SPARK-16653][ML][Optimizer] update ANN convergence tolerance param default to 1e-6

    ## What changes were proposed in this pull request?
    
    replace ANN convergence tolerance param default 
    from 1e-4 to 1e-6
    
    so that it will be the same with other algorithms in MLLib which use LBFGS as optimizer.
    
    ## How was this patch tested?
    
    Existing Test.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/WeichenXu123/spark update_ann_tol

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/14286.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14286
    
----
commit cd86df5bbb7306089c3e8e33c6e483a54b402ae9
Author: WeichenXu <weichenxu123@outlook.com>
Date:   2016-07-14T15:18:22Z

    update ann tol param default to 1e-6

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message