spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #14407: [SPARK-16779][TRIVIAL][WIP] Avoid using postfix o...
Date Fri, 29 Jul 2016 22:14:04 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14407#discussion_r72868538
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/FaultToleranceTest.scala ---
    @@ -113,7 +112,7 @@ private object FaultToleranceTest extends App with Logging {
         assertValidClusterState()
     
         killLeader()
    -    delay(30 seconds)
    +    delay(30.seconds)
    --- End diff --
    
    Yeah, I'd like to hear opinions on this. "30 seconds" seems like one of the more reasonable
usages of postfix. Is it worth keeping, or trying to get rid of cases like this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message