spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark pull request #14079: [SPARK-8425][CORE] New Blacklist Mechanism
Date Wed, 27 Jul 2016 22:39:02 GMT
Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14079#discussion_r72537531
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -266,19 +278,11 @@ private[spark] class TaskSetManager(
         taskAttempts(taskIndex).exists(_.host == host)
       }
     
    -  /**
    -   * Is this re-execution of a failed task on an executor it already failed in before
    -   * EXECUTOR_TASK_BLACKLIST_TIMEOUT has elapsed ?
    -   */
    -  private[scheduler] def executorIsBlacklisted(execId: String, taskId: Int): Boolean
= {
    -    if (failedExecutors.contains(taskId)) {
    -      val failed = failedExecutors.get(taskId).get
    -
    -      return failed.contains(execId) &&
    -        clock.getTimeMillis() - failed.get(execId).get < EXECUTOR_TASK_BLACKLIST_TIMEOUT
    -    }
    -
    -    false
    +  private def blacklistedOnExec(execId: String, host: String, index: Int): Boolean =
{
    +    blacklistTracker.map { bl =>
    --- End diff --
    
    you can use _ since b1 is never used


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message