spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark pull request #14079: [SPARK-8425][CORE] New Blacklist Mechanism
Date Wed, 27 Jul 2016 17:33:37 GMT
Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14079#discussion_r72485124
  
    --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
    @@ -204,6 +213,7 @@ case object TaskResultLost extends TaskFailedReason {
     @DeveloperApi
     case object TaskKilled extends TaskFailedReason {
       override def toErrorString: String = "TaskKilled (killed intentionally)"
    +  override def countTowardsTaskFailures: Boolean = false
    --- End diff --
    
    Ah sorry I was just confused by the inheritance here. Now that you mention it, it does
seem like it would make sense for this to be a val though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message