spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From steveloughran <...@git.apache.org>
Subject [GitHub] spark pull request #14371: [SPARK-16736] WiP Core+ SQL superfluous fs calls
Date Wed, 27 Jul 2016 12:29:26 GMT
Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14371#discussion_r72429947
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -1410,10 +1410,12 @@ class SparkContext(config: SparkConf) extends Logging with ExecutorAllocationCli
         val scheme = new URI(schemeCorrectedPath).getScheme
         if (!Array("http", "https", "ftp").contains(scheme)) {
           val fs = hadoopPath.getFileSystem(hadoopConfiguration)
    -      if (!fs.exists(hadoopPath)) {
    -        throw new FileNotFoundException(s"Added file $hadoopPath does not exist.")
    +      val isDir = try {
    +        fs.getFileStatus(hadoopPath).isDirectory
    +      } catch {
    +        case f: FileNotFoundException =>
    +          throw new FileNotFoundException(s"Added file $hadoopPath does not exist.").initCause(f)
    --- End diff --
    
    BTW, if you look at how FileSystem.exists() is implemented' it's getFileStatus with the
catch downgraded to returning false. Against S3, the status check is taking 1-3 HTTPS requests,
so measurably slow


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message