spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request #14364: [SPARK-16730][SQL] Implement function aliases for...
Date Wed, 27 Jul 2016 07:23:57 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14364#discussion_r72391502
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
    @@ -452,14 +466,36 @@ object FunctionRegistry {
           }
         }
     
    -    val clazz = tag.runtimeClass
    +    (name, (expressionInfo[T](name), builder))
    +  }
    +
    +  /**
    +   * Creates a function lookup registry for cast aliases (SPARK-16730).
    --- End diff --
    
    NIT: `...function lookup registry...` should that ben`...function registry lookup entry
...` or something similar?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message