spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request #14302: [SPARK-16663][SQL] desc table should be consisten...
Date Mon, 25 Jul 2016 14:22:23 GMT
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14302#discussion_r72071947
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
---
    @@ -520,7 +522,7 @@ case class DescribeTableCommand(table: TableIdentifier, isExtended:
Boolean, isF
     
       private def describeSchema(schema: Seq[CatalogColumn], buffer: ArrayBuffer[Row]): Unit
= {
         schema.foreach { column =>
    -      append(buffer, column.name, column.dataType.toLowerCase, column.comment.orNull)
    +      append(buffer, column.name, column.dataType.toLowerCase, column.comment.getOrElse(""))
    --- End diff --
    
    I'm not sure whether no comment or empty comment matters here though. Maybe making them
consistent makes more sense here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message