spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #14231: [SPARK-16586] Change the way the exit code of lau...
Date Sun, 24 Jul 2016 08:05:24 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14231#discussion_r71983974
  
    --- Diff: bin/spark-class ---
    @@ -65,24 +65,25 @@ fi
     # characters that would be otherwise interpreted by the shell. Read that in a while loop,
populating
     # an array that will be used to exec the final command.
     #
    -# The exit code of the launcher is appended to the output, so the parent shell removes
it from the
    -# command array and checks the value to see if the launcher succeeded.
    -build_command() {
    -  "$RUNNER" -Xmx128m -cp "$LAUNCH_CLASSPATH" org.apache.spark.launcher.Main "$@"
    -  printf "%d\0" $?
    -}
    +# To keep both the output and the exit code of the launcher, the output is first converted
to a hex
    +# dump which prevents the bash from getting rid of the NULL character, and the exit code
retrieved
    +# from the bash array ${PIPESTATUS[@]}.
    +#
    +# Note that the seperator NULL character can not be replace with space or '\n' so that
the command
    +# won't fail if some path of the user contain special characher such as '\n' or space
    +#
    +# Also note that when the launcher fails, it might not output something ending with '\0'
[SPARK-16586]
    +_CMD=$("$RUNNER" -Xmx128m -cp "$LAUNCH_CLASSPATH" org.apache.spark.launcher.Main "$@"|xxd
-p|tr -d '\n';exit ${PIPESTATUS[0]})
    --- End diff --
    
    Is it easier to just check the exit status of this process with `$?` and exit with a better
message if not 0?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message